Skip to content

Revise Specification API #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Jun 20, 2024 · 1 comment
Closed

Revise Specification API #3521

christophstrobl opened this issue Jun 20, 2024 · 1 comment
Assignees
@mp911de
Labels
has: design-decision An issue that contains a design decision about its topic type: enhancement A general enhancement
Milestone
4.0 M1 (2025.1.0)

Comments

@christophstrobl
Copy link
Member

Due to how CriteriaQuery and CriteriaDelete are structured in jakarta.persistence the toPredicate method of Specification can not be used for deletes because of its CriteriaQuery parameter.
We should find a way to allow users to express their needs in another way than having to pass in null to satisfy the API.

Related to: #3036
@christophstrobl christophstrobl added status: pending-design-work Needs design work before any code can be developed has: design-decision An issue that contains a design decision about its topic labels Jun 20, 2024
christophstrobl added a commit that referenced this issue Jun 21, 2024
@christophstrobl
Update nullability annotations and javadoc.
d60efe6 
Reflect allowed null arguments in both documentation as well as supporting annotations.
Going forward we should consider if there is a possibility to restructure Specification and the Predicate handling to avoid this at all (#3521).

See: #3036
@mp911de mp911de self-assigned this Aug 13, 2024
@mp911de mp911de added the type: enhancement A general enhancement label Aug 13, 2024
@mp911de mp911de mentioned this issue Aug 13, 2024
Closed
@mp911de mp911de linked a pull request Oct 28, 2024 that will close this issue
Refine Specification API #3578
Closed
christophstrobl pushed a commit that referenced this issue Jan 8, 2025
@mp911de @christophstrobl
Explore refined Specification API.
578f539 
Introduce DeleteSpecification and UpdateSpecification. Add PredicateSpecification. Update SpecificationExecutor.

Closes: #3521
Original Pull Request: #3578
@christophstrobl
Copy link
Member Author

merged to 4.0.x

@mp911de mp911de changed the title Investigate 'slim' Specification API Revise Specification API Jan 9, 2025
@mp911de mp911de removed the status: pending-design-work Needs design work before any code can be developed label Jan 9, 2025
@mp911de mp911de added this to the 4.0 M1 (2025.1.0) milestone Jan 9, 2025
mp911de added a commit that referenced this issue Jan 14, 2025
@mp911de
Explore refined Specification API.
ae79ff5 
Introduce DeleteSpecification and UpdateSpecification. Add PredicateSpecification. Update SpecificationExecutor.

Closes: #3521
Original Pull Request: #3578
mp911de added a commit that referenced this issue Jan 15, 2025
@mp911de
Polishing.
3001f73 
Fix since versions.

See: #3521
Original Pull Request: #3578
mp911de added a commit that referenced this issue Mar 17, 2025
@mp911de
Explore refined Specification API.
a33af7c 
Introduce DeleteSpecification and UpdateSpecification. Add PredicateSpecification. Update SpecificationExecutor.

Closes: #3521
Original Pull Request: #3578
mp911de added a commit that referenced this issue Mar 17, 2025
@mp911de
Polishing.
422598b 
Fix since versions.

See: #3521
Original Pull Request: #3578
mp911de added a commit that referenced this issue Apr 14, 2025
@mp911de
Explore refined Specification API.
8d942bd 
Introduce DeleteSpecification and UpdateSpecification. Add PredicateSpecification. Update SpecificationExecutor.

Closes: #3521
Original Pull Request: #3578
mp911de added a commit that referenced this issue Apr 14, 2025
@mp911de
Polishing.
597f929 
Fix since versions.

See: #3521
Original Pull Request: #3578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
has: design-decision An issue that contains a design decision about its topic type: enhancement A general enhancement
Projects
None yet
Milestone
4.0 M1 (2025.1.0)
Development

Successfully merging a pull request may close this issue.

Refine Specification API spring-projects/spring-data-jpa
2 participants
@mp911de @christophstrobl