Skip to content

Drop SpEL support in the HQL/JPQL grammars #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gregturn opened this issue Mar 22, 2023 · 0 comments
Closed

Drop SpEL support in the HQL/JPQL grammars #2881

gregturn opened this issue Mar 22, 2023 · 0 comments
Assignees
@gregturn
Labels
in: query-parser Everything related to parsing JPQL or SQL type: task A general task
Milestone
3.1 RC1 (2023.0.0)

Comments

@gregturn
Copy link
Contributor

When first created, we needed SpEL support. That was due to eager creation of count queries. However, with 5f244c4 in place, there is no longer any need to handle SpEL expressions, so we can remove it from the grammars.
@gregturn gregturn self-assigned this Mar 22, 2023
@gregturn gregturn added type: task A general task in: query-parser Everything related to parsing JPQL or SQL labels Mar 22, 2023
@gregturn gregturn added this to the 3.1 RC1 (2023.0.0) milestone Mar 22, 2023
@gregturn gregturn mentioned this issue Mar 22, 2023
Closed
gregturn added a commit that referenced this issue Mar 22, 2023
@gregturn
Drop support for SpEL expressions in the query parsers.
b7aab64 
By delaying the creation of count queries beyond the point where SpEL evaluation is carried out, there is no longer a need to handle SpEL expressions in the query parsers.

Resolves #2881.
@gregturn gregturn linked a pull request Mar 22, 2023 that will close this issue
Drop SpEL support in the query parsers. #2882
Closed
klajdipaja pushed a commit to klajdipaja/spring-data-jpa that referenced this issue Mar 24, 2023
@gregturn @klajdipaja
Drop support for SpEL expressions in the query parsers.
799a1c7 
By delaying the creation of count queries beyond the point where SpEL evaluation is carried out, there is no longer a need to handle SpEL expressions in the query parsers.

Resolves spring-projects#2881.
Original pull request: spring-projects#2882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
in: query-parser Everything related to parsing JPQL or SQL type: task A general task
Projects
None yet
Milestone
3.1 RC1 (2023.0.0)
Development

Successfully merging a pull request may close this issue.

Drop SpEL support in the query parsers. spring-projects/spring-data-jpa
1 participant
@gregturn