SimpleJPARepository: Methods accessing metadata.getComment() without Null-Check produce NPE

[jpeschke2608]

Hi there,
Stumbled upon a Null Pointer Exception during Migration to Spring Boot 3.0.0 (and spring-data-jpa 3.0.0) that seems to be raised when accessing the "getComment" method on the metadata field of SimpleJPARepository:

The two methods "applyQueryHints" and "applyQueryHintsForCount()" don't perform a null check on the metadata field of SimpleJPARepository (which is annotated as @nullable), e.g.:

private void applyQueryHintsForCount(Query query) {
	getQueryHintsForCount().forEach(query::setHint);

       // NPE is thrown here, if metadata is null!
	if (metadata.getComment() != null && provider.getCommentHintKey() != null) {
		query.setHint(provider.getCommentHintKey(), provider.getCommentHintValue(metadata.getComment()));
	}
}

In other methods of the repository, it seems to be correct, e.g.:

private <S> TypedQuery<S> applyRepositoryMethodMetadata(TypedQuery<S> query) {
	if (metadata == null) {
	   return query;
	}
	LockModeType type = metadata.getLockModeType();
       ...
}	

Thanks for any ideas for smooth workarounds or other input,

Joerg

[gregturn]

Indeed, there are spots where the invoke of that method did a null check, but other spots where it does not.

[gregturn]

I added additional null checks in applyQueryHints and applyQueryHintsForCount to further guard against this.

[dickerpulli]

@gregturn Unfortunately the commits f40b39c and b0aa2b6 has not been pushed to the 3.0.x branch, so they were not a part of the 3.0.1 release. Could you please add them to the 3.0.x branch, so that they are at least included in next release 3.0.2?

Thanks.

P.S: Maybe @mp911de can do this also ... :-)

[gregturn]

I believe this was merged to main right after main rolled to 3.1.x. I've backported this fix to 3.0.x via 7dce3d1.