Skip to content

Merge Spring Data Envers into Spring Data JPA project #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mp911de opened this issue Sep 21, 2021 · 4 comments
Closed

Merge Spring Data Envers into Spring Data JPA project #2316

mp911de opened this issue Sep 21, 2021 · 4 comments
Assignees
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Sep 21, 2021

JPA is a foundational technology for Envers and Envers is a specific enhancement to Hibernate. It makes sense to keep both projects colocated within the same repository for easier maintenance and dependency alignment.

@scordio
Copy link
Contributor

scordio commented Sep 21, 2021

Out of curiosity, will the JPA project become a multi-module, or will Envers classes be moved inside the JPA module?

I'm asking it because recently the auto-configuration for Envers has been added to Spring Boot with spring-projects/spring-boot@fbbfe6a and there is an ImportSelector that checks if org.springframework.data.envers.repository.config.EnableEnversRepositories is in the classpath.

If the JPA module contains Envers classes, Envers will always be auto-configured and I don't know if this is the behavior you would expect. Maybe the auto-configuration should be evaluated again (or dropped?)

@mp911de
Copy link
Member Author

mp911de commented Sep 21, 2021

Spring Data JPA will become a multi-module project. From a consumer perspective, nothing is going to change, artifact Id's and the source separation will remain to not break downstream users.

@scordio
Copy link
Contributor

scordio commented Sep 21, 2021

Thanks for the clarification, @mp911de.

@schauder schauder transferred this issue from spring-projects/spring-data-envers Sep 27, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 27, 2021
@schauder schauder added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2021
@schauder schauder self-assigned this Sep 27, 2021
@schauder
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants