Skip to content

DATAES-764 - StreamQueries#streamResults does not clear scroll context when finished #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

DATAES-764 - StreamQueries#streamResults does not clear scroll context when finished #406

merged 1 commit into from
Mar 18, 2020

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Mar 17, 2020 •
edited
Loading

This fixes the issue DATAES-764.
It should be backported to 3.2.x (Moore).

@sothawo mind taking a look.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@xhaggi xhaggi requested a review from sothawo March 17, 2020 17:07
@xhaggi
Copy link
Contributor Author

xhaggi commented Mar 17, 2020

By the way, I'm not sure how to create a reasonable test case for this fix, since ES only logs a warning.

@xhaggi
Copy link
Contributor Author

xhaggi commented Mar 17, 2020 •
edited
Loading

Since we are on ES 7.x, it is possible to add a test that checks my changes. But this test case has no effect on 3.2.x (Moore).

@sothawo
Copy link
Collaborator

sothawo commented Mar 17, 2020

I'll have a look at it

sothawo
sothawo requested changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor comment in the code, but please change the test.
If you want to merge and backport feel free to do so, otherwise just notify me, and I will do this.

@xhaggi xhaggi requested a review from sothawo March 18, 2020 08:24
@sothawo sothawo merged commit f103bdb into spring-projects:master Mar 18, 2020
sothawo pushed a commit that referenced this pull request Mar 18, 2020
@xhaggi @sothawo
DATAES-764 - StreamQueries#streamResults does not clear scroll contex…
e22e2bb 
…t when finished.

Original PR: #406

(cherry picked from commit f103bdb)
@xhaggi xhaggi deleted the DATAES-764 branch March 19, 2020 08:12
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
@Stexxen Stexxen mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sothawo sothawo Awaiting requested review from sothawo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhaggi @sothawo