DATAES-680 - ReactiveElasticsearchTemplate-should-use-the-count-API. #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sothawo
force-pushed
the
DATAES-680_-_ReactiveElasticsearchTemplate-should-use-the-count-API
branch
from
4dca94b to
f98fd3c
Compare
sothawo
force-pushed
the
DATAES-680_-_ReactiveElasticsearchTemplate-should-use-the-count-API
branch
from
f98fd3c to
b671261
Compare
mp911de
approved these changes
Nov 6, 2019
sothawo
deleted the
DATAES-680_-_ReactiveElasticsearchTemplate-should-use-the-count-API
branch
|
I agree. But doing this as long as the TransportClient is supported means additional work which will be obsolete in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the reactive stack in order to do a count does a search and counts the returned flux. This means that all records are read to get the count which is quite not performant.
This PR uses the count API of Elasticsearch to do a count.
This is somehow related to #340 but I want to keep this in a separate PR, as this feature should be merged into 3.2.x regardless of the rewriting in the current master branch.