Skip to content

Add count methods to ELC's ReactiveElasticsearchClient. #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
* Reactive version of {@link co.elastic.clients.elasticsearch.ElasticsearchClient}.
*
* @author Peter-Josef Meisch
* @author maryantocinn
* @since 4.4
*/
public class ReactiveElasticsearchClient extends ApiClient<ElasticsearchTransport, ReactiveElasticsearchClient>
Expand Down Expand Up @@ -227,6 +228,26 @@ public Mono<DeleteByQueryResponse> deleteByQuery(
return deleteByQuery(fn.apply(new DeleteByQueryRequest.Builder()).build());
}

/**
* @since 5.4
*/
public Mono<CountResponse> count(CountRequest request) {

Assert.notNull(request, "request must not be null");

return Mono.fromFuture(transport.performRequestAsync(request, CountRequest._ENDPOINT, transportOptions));
}

/**
* @since 5.4
*/
public Mono<CountResponse> count(Function<CountRequest.Builder, ObjectBuilder<CountRequest>> fn) {

Assert.notNull(fn, "fn must not be null");

return count(fn.apply(new CountRequest.Builder()).build());
}

// endregion
// region search

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import co.elastic.clients.elasticsearch._types.mapping.TypeMapping;
import co.elastic.clients.elasticsearch.cluster.HealthRequest;
import co.elastic.clients.elasticsearch.cluster.HealthResponse;
import co.elastic.clients.elasticsearch.core.CountRequest;
import co.elastic.clients.elasticsearch.core.CountResponse;
import co.elastic.clients.elasticsearch.core.IndexRequest;
import co.elastic.clients.elasticsearch.core.IndexResponse;
import co.elastic.clients.elasticsearch.core.SearchRequest;
Expand Down Expand Up @@ -62,6 +64,7 @@
* on port 9200 and an intercepting proxy on port 8080.
*
* @author Peter-Josef Meisch
* @author maryantocinn
*/
@Disabled
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
Expand Down Expand Up @@ -352,6 +355,43 @@ private ResponseBody<EntityAsMap> searchImperative(SearchRequest searchRequest)
private ResponseBody<EntityAsMap> searchReactive(SearchRequest searchRequest) {
return Objects.requireNonNull(reactiveElasticsearchClient.search(searchRequest, EntityAsMap.class).block());
}

// endregion
// region count
@Test
@Order(40)
void count() {

CountRequest countRequest = new CountRequest.Builder().index(INDEX)
.query(query -> query.match(matchQuery -> matchQuery.field("content").query(FieldValue.of("content1"))))
.build();

CountResponse countResponse = null;

try {
countResponse = countImperative(countRequest);
assertThat(countResponse).isNotNull();
assertThat(countResponse.count()).isEqualTo(1);
} catch (IOException e) {
LOGGER.error("error", e);
}

try {
countResponse = countReactive(countRequest);
assertThat(countResponse).isNotNull();
assertThat(countResponse.count()).isEqualTo(1);
} catch (Exception e) {
LOGGER.error("error", e);
}
}

private CountResponse countImperative(CountRequest countRequest) throws IOException {
return imperativeElasticsearchClient.count(countRequest);
}

private CountResponse countReactive(CountRequest countRequest) {
return Objects.requireNonNull(reactiveElasticsearchClient.count(countRequest).block());
}
// endregion

private ClientConfiguration clientConfiguration() {
Expand Down