Skip to content

Support for SQL. #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 6, 2024
Merged

Support for SQL. #2949

merged 6 commits into from
Aug 6, 2024

Conversation

youssef3wi
Copy link
Contributor

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2683

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 31, 2024
@youssef3wi youssef3wi marked this pull request as ready for review August 1, 2024 11:56
@youssef3wi
Copy link
Contributor Author

I should add some test case to verify complex results such as SELECT SUM(views) FROM x.

sothawo
sothawo requested changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this; just some minor remarks/questions

@youssef3wi youssef3wi requested a review from sothawo August 4, 2024 08:54
sothawo
sothawo requested changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't compile 😁

@youssef3wi youssef3wi requested a review from sothawo August 4, 2024 15:31
@sothawo sothawo merged commit 738ee54 into spring-projects:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sothawo sothawo Awaiting requested review from sothawo

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spring-data-elasticsearch doesn't support elasticsearch sql
3 participants
@youssef3wi @sothawo @spring-projects-issues