DATAES-570 - Use Delete By Query API for delete by query operations. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xhaggi
commented
Apr 26, 2019
xhaggi
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
|
This PR needs #279 to pass the tests successfully |
xhaggi
force-pushed
the
DATAES-570
branch
4 times, most recently
from
ed297f8 to
cc871b2
Compare
|
@christophstrobl @sothawo would you mind taking a look? |
sothawo
reviewed
Apr 26, 2019
src/main/java/org/springframework/data/elasticsearch/core/ElasticsearchRestTemplate.java
Show resolved
Hide resolved
sothawo
approved these changes
Apr 26, 2019
src/main/java/org/springframework/data/elasticsearch/core/ElasticsearchRestTemplate.java
Outdated
Show resolved
Hide resolved
|
@sothawo force-pushed with all comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.