Extend BulkFailureException.failedDocuments return type to show more details about failure #2633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a bulk operation (insert or update) fails, there maybe a need to handle a failure of every document in a specific way based on a reason of failure.
Relying on a
String
error message coming from native Elasticsearch library (the current implementation) is not reliable, as requires checking for a specific sub-string, and the message itself may change in the future.This PR proposes a change, which will expose an HTTP response code (taken from https://artifacts.elastic.co/javadoc/co/elastic/clients/elasticsearch-java/7.17.0/co/elastic/clients/elasticsearch/core/bulk/BulkResponseItem.html#status()) in addition to currently exposed error message, so that it will be much more convenient to handle specific failure reasons (e.g. 409 - conflict, when trying to save a document with version less than or equal to the currently stored in Elasticsearch).
Closes #2619