Skip to content

Implement the point in time API. #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

Implement the point in time API. #2273

merged 1 commit into from
Aug 17, 2022

Conversation

sothawo
Copy link
Collaborator

@sothawo sothawo commented Aug 17, 2022

Closes #1684

@sothawo sothawo merged commit 46cd4cd into spring-projects:main Aug 17, 2022
@sothawo sothawo mentioned this pull request Aug 17, 2022
Closed
@sothawo sothawo deleted the #1684-PIT-API branch August 20, 2022 13:33
@sothawo sothawo mentioned this pull request Aug 20, 2022
Merged
sothawo added a commit that referenced this pull request Aug 20, 2022
@sothawo
Reactive implementation of the point in time API.
18be558 
This PR adds the reactive implementation for the point in time API that was missing in #2273.

Original Pull Request #2275
Closes #2274
puppylpg
puppylpg reviewed Nov 10, 2022
View reviewed changes
src/main/asciidoc/reference/elasticsearch-misc.adoc
== Point In Time (PIT) API

`ElasticsearchOperations` supports the point in time API of Elasticsearch (see https://www.elastic
.co/guide/en/elasticsearch/reference/8.3/point-in-time-api.html). The following code snippet shows how to use this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong line break here 😄

preview

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm currently checking the documentation anyway for the next release, so this will go in there as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, will PIT be added into 4.x release? I didn't find milestones related to this pr.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was in 5.0.M6 (I obviously was neglecting setting the milestones when closing issues this summer). So it will be in version 5.

It won't be backported to 4.4. After a version (minor) is released, it will be only updated with bugfixes and dependency patch updates, not with new features or API changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puppylpg puppylpg puppylpg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for point_in_time search API
2 participants
@sothawo @puppylpg