Skip to content

[elc] add convenient methods to improve access to aggregations #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Aug 9, 2022

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our [issue tracker](https://github.
    com/spring-projects/spring-data-elasticsearch/issues)
    . Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2265

@xhaggi xhaggi force-pushed the 2265-improve-access-to-aggregations branch from 3e303f3 to 74c6c55 Compare August 9, 2022 09:52
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 9, 2022
@xhaggi xhaggi force-pushed the 2265-improve-access-to-aggregations branch from 74c6c55 to 64ba269 Compare August 9, 2022 13:13
@xhaggi xhaggi requested a review from sothawo August 9, 2022 14:57
@xhaggi xhaggi force-pushed the 2265-improve-access-to-aggregations branch from 64ba269 to 824e841 Compare August 10, 2022 08:01
Copy link
Contributor Author

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the ctor with the list type and adjusted the code according to your comments.

@xhaggi xhaggi requested a review from sothawo August 10, 2022 08:05
@sothawo sothawo merged commit c930394 into spring-projects:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve access to aggregations of SearchHits
3 participants