Skip to content

DATAES-467 - fix sorting by _score if spring-data sort is used #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2018
Merged

DATAES-467 - fix sorting by _score if spring-data sort is used #209

merged 1 commit into from
Jun 18, 2018

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Jun 14, 2018 •
edited
Loading

See https://jira.spring.io/browse/DATAES-467

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@xhaggi xhaggi requested a review from akonczak June 14, 2018 14:35
akonczak
akonczak reviewed Jun 15, 2018
View reviewed changes
Copy link
Contributor

@akonczak akonczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good - only small adjustment required for test

src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java

// then
assertThat(sampleEntities.getTotalElements(), equalTo(3L));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check order of elements here not just size of the result

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really necessary, because without the fix it will throws an exception.

@xhaggi xhaggi merged commit b51a370 into spring-projects:master Jun 18, 2018
odrotbohm pushed a commit that referenced this pull request Jun 18, 2018
@xhaggi @odrotbohm
DATAES-467 - Fix sorting by _score if Spring Data sort is used.
020b5e1 
Original pull request: #209.
odrotbohm pushed a commit that referenced this pull request Jun 18, 2018
@xhaggi @odrotbohm
DATAES-467 - Fix sorting by _score if Spring Data sort is used.
ba3eba5 
Original pull request: #209.
@donrw donrw mentioned this pull request Jun 19, 2018
Merged
5 tasks
@ptahchiev
Copy link
Contributor

I believe this needs to be backported to Kay too.

xhaggi added a commit that referenced this pull request Jun 22, 2018
@xhaggi
DATAES-467 - Fix sorting by _score if Spring Data sort is used.
37bc97d 
Original pull request: #209.
@xhaggi xhaggi deleted the DATAES-467 branch June 28, 2018 15:09
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akonczak akonczak akonczak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xhaggi @ptahchiev @akonczak