Skip to content

Add missing hashCode and equals methods to JoinField #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Jun 22, 2021

Closes #1846

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@xhaggi xhaggi requested a review from sothawo June 22, 2021 10:20
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 22, 2021
@sothawo sothawo merged commit a16a87f into spring-projects:main Jun 22, 2021
@xhaggi
Copy link
Contributor Author

xhaggi commented Jun 23, 2021

@sothawo should we backport the changes to 4.2.x?

@xhaggi xhaggi deleted the 1846-missing-joinfield-hashcode-equals branch June 23, 2021 08:12
@sothawo
Copy link
Collaborator

sothawo commented Jun 23, 2021

fair point; I'll do this this evening

sothawo pushed a commit that referenced this pull request Jun 23, 2021
Original Pull Request #1847
Closes #1846

(cherry picked from commit a16a87f)
sothawo pushed a commit that referenced this pull request Jun 23, 2021
Original Pull Request #1847
Closes #1846

(cherry picked from commit a16a87f)
(cherry picked from commit 0bb239a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing hashCode and equals methods in JoinField
3 participants