Skip to content

Types are in the process of being removed. #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

rahulmlokurte
Copy link
Contributor

@rahulmlokurte rahulmlokurte commented Apr 2, 2021

RestClientConfig should use only index as the types are being deprecated.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

RestClientConfig should use only index as the types are being deprecated.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 2, 2021
@sothawo sothawo merged commit d66f8a0 into spring-projects:master Apr 3, 2021
@sothawo
Copy link
Collaborator

sothawo commented Apr 3, 2021

Thanks for the PR and pointing this out. As the types are currently only deprecated, using them is still allowed. But you're right, we should not use deprecated code in our examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants