#1668 Fix subCriteria's not being updated #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slyoldfox
commented
Jan 27, 2021
•
slyoldfox
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our issue tracker.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
|
@slyoldfox Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
sothawo
requested changes
Jan 28, 2021
| Criteria.or() | ||
| .subCriteria( Criteria.where("birthDate") // | ||
| .between(LocalDate.of(1989, 11, 9), LocalDate.of(1990, 11, 9)) ) // | ||
| .subCriteria( Criteria.where( "createdDate").is(calendar.getTime()) ) // |
There was a problem hiding this comment.
Suggested change
| .subCriteria( Criteria.where( "createdDate").is(calendar.getTime()) ) // | |
| .subCriteria( Criteria.where( "createdDate").is(383745721653L) ) // |
no need for the Calendar stuff here (I'd not use the old java.util date classes anyway, but always the classes from java.time).
| @@ -109,6 +108,158 @@ void shouldMapNamesAndConvertValuesInCriteriaQuery() throws JSONException { | |||
| assertEquals(expected, queryString, false); | |||
| } | |||
|
|
|||
| @Test | |||
| // DATAES-1668 | |||
There was a problem hiding this comment.
Suggested change
| // DATAES-1668 | |
| // #1668 |
DATAES was when we were using Jira, now we just use the #NNN
| } | ||
|
|
||
| @Test | ||
| // DATAES-1668 |
There was a problem hiding this comment.
Suggested change
| // DATAES-1668 | |
| // #1668 |
spring-projects-issues
added
the
status: waiting-for-triage
|
@slyoldfox Thank you for signing the Contributor License Agreement! |
|
@sothawo Not a git wizard here - I hope I ticked off all the steps as required :-) |
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.