Skip to content

NodeClientFactoryBean doesn't shutdown ES on destroy life-cycle. [DATAES-314] #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Dec 6, 2016 · 2 comments
Closed

NodeClientFactoryBean doesn't shutdown ES on destroy life-cycle. [DATAES-314] #887

spring-projects-issues opened this issue Dec 6, 2016 · 2 comments
Labels
in: core Issues in core support type: task A general task
Milestone
4.0 M1 (Neumann)

Comments

@spring-projects-issues
Copy link

Friederich Christophe opened DATAES-314 and commented

The class NodeClientFactoryBean releases only NodeClient, call close() method has no effect. NodeClientFactoryBean must call close() method on node client and node as well to complete the shutdown cycle of ES

Affects: 3.0 M1 (Kay)

Referenced from: pull request #333

1 votes, 3 watchers
@spring-projects-issues
Copy link
Author

sothawo commented

btw we need the NodeClient (which is not deprecated in ES7) and the Node as long as we start a node in the tests with the xml configuration. The JUnit4 rule I wrote a couple of tickets ago, starts a node as well and class node.close() but is not using the NodeClientFactoryBean.

 

@spring-projects-issues
Copy link
Author

sothawo commented

this seems to break builds in the pipeline that fail with
java.net.ConnectException: Connection refused
So this needs further investigation

@spring-projects-issues spring-projects-issues added in: core Issues in core support type: task A general task labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core Issues in core support type: task A general task
Projects
None yet
Milestone
4.0 M1 (Neumann)
Development

No branches or pull requests
1 participant
@spring-projects-issues