NodeClientFactoryBean doesn't shutdown ES on destroy life-cycle. [DATAES-314]

[spring-projects-issues]

Friederich Christophe opened DATAES-314 and commented

The class NodeClientFactoryBean releases only NodeClient, call close() method has no effect. NodeClientFactoryBean must call close() method on node client and node as well to complete the shutdown cycle of ES

---

Affects: 3.0 M1 (Kay)

Referenced from: pull request #333

1 votes, 3 watchers

[spring-projects-issues]

sothawo commented

btw we need the NodeClient (which is not deprecated in ES7) and the Node as long as we start a node in the tests with the xml configuration. The JUnit4 rule I wrote a couple of tickets ago, starts a node as well and class node.close() but is not using the NodeClientFactoryBean.

 

[spring-projects-issues]

sothawo commented

this seems to break builds in the pipeline that fail with
java.net.ConnectException: Connection refused
So this needs further investigation