Skip to content

DeleteQuery > refresh field is unused #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tuguri8 opened this issue Aug 29, 2024 · 1 comment · Fixed by #2976
Closed

DeleteQuery > refresh field is unused #2973

tuguri8 opened this issue Aug 29, 2024 · 1 comment · Fixed by #2976
Assignees
@tuguri8
Labels
type: bug A general bug

Comments

@tuguri8
Copy link
Contributor

tuguri8 commented Aug 29, 2024

Hello,

I saw that refresh field on DeleteQuery is unused.

It seems to work differently than described in the javadoc (setting refresh=true doesn't seem to trigger refresh)

I think we should set the refresh based on the DeleteQuery > refresh field in documentDeleteByQueryRequest method, I'll open PR if you agree!
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2024
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 30, 2024
@sothawo
Copy link
Collaborator

sothawo commented Aug 30, 2024

fell free to implement this

This was referenced Sep 2, 2024
Merged
Closed
@sothawo sothawo closed this as completed in b1b232d Sep 3, 2024
sothawo pushed a commit that referenced this issue Sep 3, 2024
@tuguri8 @sothawo
Set refresh on DeleteByQueryRequest by DeleteQuery.
3a9a959 
Original Pull Request #2976
Closes #2973

(cherry picked from commit b1b232d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuguri8 tuguri8

Labels
type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set refresh on DeleteByQueryRequest by DeleteQuery tuguri8/spring-data-elasticsearch
3 participants
@sothawo @spring-projects-issues @tuguri8