Skip to content

ReactiveIndicesTemplate: Refresh not called on bound indices #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ls-urs-keller opened this issue Feb 2, 2023 · 2 comments · Fixed by #2444
Closed

ReactiveIndicesTemplate: Refresh not called on bound indices #2441

ls-urs-keller opened this issue Feb 2, 2023 · 2 comments · Fixed by #2444
Labels
type: bug A general bug
Milestone
5.1 M1 (2023.0.0)

Comments

@ls-urs-keller
Copy link
Contributor

spring-data-elasticsearch/src/main/java/org/springframework/data/elasticsearch/client/elc/ReactiveIndicesTemplate.java

Line 156 in b75d2eb

public Mono<Void> refresh() {

Shouldn't this be

	@Override
	public Mono<Void> refresh() {
		RefreshRequest refreshRequest = requestConverter.indicesRefreshRequest(getIndexCoordinates());
		return Mono.from(execute(reactiveOpenSearchIndicesClient -> reactiveOpenSearchIndicesClient.refresh(
				refreshRequest))).then();
	}

I can PR just would like to have a confirmation that this is a bug.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 2, 2023
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 3, 2023
@sothawo
Copy link
Collaborator

sothawo commented Feb 3, 2023

Thank you for that finding, indeed that's a bug. Please provide a PR for the main branch, I'll backport it then to the 5.0.x as well.

ls-urs-keller added a commit to ls-urs-keller/spring-data-elasticsearch that referenced this issue Feb 3, 2023
@ls-urs-keller
Fix ReactiveIndicesTemplate: Refresh not called on bound indices spri…
30b10e1 
…ng-projects#2441
ls-urs-keller added a commit to ls-urs-keller/spring-data-elasticsearch that referenced this issue Feb 3, 2023
@ls-urs-keller
Fix ReactiveIndicesTemplate: Refresh not called on bound indices spri…
e5cc1cd 
…ng-projects#2441
@ls-urs-keller ls-urs-keller mentioned this issue Feb 3, 2023
Merged
5 tasks
@ls-urs-keller
Copy link
Contributor Author

ls-urs-keller commented Feb 3, 2023 •
edited
Loading

@sothawo Thank for your quick reply, pull request added.

sothawo pushed a commit that referenced this issue Feb 3, 2023
@ls-urs-keller
Fix ReactiveIndicesTemplate: Refresh not called on bound indices.
0971acf 
Original Pull Request #2444
Closes #2441
@sothawo sothawo added this to the 5.1 M1 (2023.0.0) milestone Feb 3, 2023
sothawo pushed a commit that referenced this issue Feb 3, 2023
@ls-urs-keller @sothawo
Fix ReactiveIndicesTemplate: Refresh not called on bound indices.
5cf7b2b 
Original Pull Request #2444
Closes #2441

(cherry picked from commit 0971acf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
5.1 M1 (2023.0.0)
3 participants
@sothawo @spring-projects-issues @ls-urs-keller