Skip to content

Make the new client the default, deprecate the RestHighLevelClient and make it optional #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue May 11, 2022 · 3 comments · Fixed by #2208
Closed

Make the new client the default, deprecate the RestHighLevelClient and make it optional #2159

sothawo opened this issue May 11, 2022 · 3 comments · Fixed by #2208
Labels
type: task A general task version-5-only

Comments

@sothawo
Copy link
Collaborator

sothawo commented May 11, 2022

No description provided.

@sothawo sothawo mentioned this issue May 25, 2022
Closed
@sothawo sothawo mentioned this issue Jul 3, 2022
Merged
sothawo added a commit that referenced this issue Jul 3, 2022
@sothawo
Make the new client the default.
094e79d 
Original Pull Request #2208
Closes #2159
@ztomic
Copy link

ztomic commented Jul 4, 2022 •
edited
Loading

Hi, with new client IndicesTemplate is missing getAliases and getAliasesForIndex implementations (https://github.com/spring-projects/spring-data-elasticsearch/blob/main/src/main/java/org/springframework/data/elasticsearch/client/elc/IndicesTemplate.java#L279). Is it by mistake or user of library must implement that calls on their own since new client is now default?

@sothawo
Copy link
Collaborator Author

sothawo commented Jul 4, 2022

@ztomic thanks for pointing this out. I missed that, created #2209 for that

@ztomic
Copy link

ztomic commented Jul 4, 2022

No problems, I spotted that while trying to test new version on product running on Spring Boot 2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task version-5-only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the new client the default sothawo/spring-data-elasticsearch
2 participants
@ztomic @sothawo