Skip to content

@Query annotation fails to parse Collection parameters in ReactiveRepository #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
buseynehannes opened this issue Apr 12, 2022 · 0 comments · Fixed by #2182
Closed

@Query annotation fails to parse Collection parameters in ReactiveRepository #2135

buseynehannes opened this issue Apr 12, 2022 · 0 comments · Fixed by #2182
Labels
type: bug A general bug

Comments

@buseynehannes
Copy link

related to #1858

The @Query Annotation doesn't work correctly when using the ReactiveCrudRepository and a parameter of the type Collection.

Looking at the StringQueryUtil class, the non-reactive repository uses ParametersParameterAccessor, the reactive one uses ConvertingParameterAccessor which iterates over the parameter list.
Creating a custom object instead of a Collection also doesn't seem to be feasible to represent a collection of String since all doublequotes are escaped by the StringQueryUtil
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 12, 2022
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 12, 2022
diamondT added a commit to diamondT/spring-data-elasticsearch that referenced this issue Jun 5, 2022
@diamondT
Fix handling of array-of-strings parameters for @Query-annotated quer…
1970cc3 
…ies.

Fixes spring-projects#2135
@diamondT diamondT mentioned this issue Jun 5, 2022
Merged
sothawo pushed a commit that referenced this issue Jun 27, 2022
@diamondT
Fix handling of array-of-strings parameters for @Query-annotated quer…
259c43a 
…ies.

Original Pull Request  #2182
Closes #2135
sothawo pushed a commit that referenced this issue Jul 12, 2022
@diamondT @sothawo
Fix handling of array-of-strings parameters for @Query-annotated quer…
aa4aeca 
…ies.

Original Pull Request  #2182
Closes #2135

(cherry picked from commit 259c43a)
sothawo pushed a commit that referenced this issue Jul 12, 2022
@diamondT @sothawo
Fix handling of array-of-strings parameters for @Query-annotated quer…
474ff84 
…ies.

Original Pull Request  #2182
Closes #2135

(cherry picked from commit 259c43a)
(cherry picked from commit aa4aeca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
No milestone
3 participants
@sothawo @spring-projects-issues @buseynehannes