Skip to content

Remove inner call to get internal field (MappingElasticsearchConverter) #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AntonLGVS opened this issue Nov 19, 2021 · 0 comments · Fixed by #2003
Closed

Remove inner call to get internal field (MappingElasticsearchConverter) #2002

AntonLGVS opened this issue Nov 19, 2021 · 0 comments · Fixed by #2003
Labels
type: enhancement A general enhancement
Milestone
4.4 M1 (2021.2.0)

Comments

@AntonLGVS
Copy link
Contributor

There is a proposal to remove the inner method getConversions() from MappingElasticsearchConverter to get the inner field. From my point of view, this will make the code a little cleaner.
AntonLGVS added a commit to AntonLGVS/spring-data-elasticsearch that referenced this issue Nov 19, 2021
@AntonLGVS
issue spring-projects#2002 - Removed getting internal field via class…
5d3a4c5 
… method
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 19, 2021
@AntonLGVS AntonLGVS mentioned this issue Nov 19, 2021
Merged
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 20, 2021
sothawo pushed a commit that referenced this issue Nov 20, 2021
@AntonLGVS
Removed getting internal field via class method.
29d2100 
Original Pull Request #2003
Closes #2002
@sothawo sothawo added this to the 4.4 M1 (2022.0.0) milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.4 M1 (2021.2.0)
3 participants
@AntonLGVS @sothawo @spring-projects-issues