Skip to content

Remove usage of org.elasticsearch classes from non-template classes #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue Jul 27, 2021 · 1 comment · Fixed by #1913
Closed

Remove usage of org.elasticsearch classes from non-template classes #1885

sothawo opened this issue Jul 27, 2021 · 1 comment · Fixed by #1913
Assignees
@sothawo
Labels
type: task A general task
Milestone
4.3 M3 (2021.1.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Jul 27, 2021

We need to remove usages of org.elasticsearch classes. The only classes where we must actually keep this is in the concrete implementations of the (Reactive)ElasticsearchOperations classes.

Once the new Elasticsearch client is available, we will not be able to use theses classes anymore. For enums or callbacks we need to provide our own similar classes and provide a mapping in the *Template classes.
@sothawo sothawo added the type: task A general task label Jul 27, 2021
@sothawo sothawo added this to the 4.3 M2 (2021.1.0) milestone Jul 27, 2021
@sothawo sothawo mentioned this issue Jul 27, 2021
Closed
@sothawo sothawo self-assigned this Aug 2, 2021
@sothawo sothawo mentioned this issue Aug 15, 2021
Closed
@sothawo
Copy link
Collaborator Author

sothawo commented Aug 29, 2021

2 parts are not resolved in this issue:

  • suggest API
  • aggregation results

These will be addressed in separate issue

@sothawo sothawo mentioned this issue Aug 30, 2021
Merged
sothawo added a commit that referenced this issue Aug 30, 2021
@sothawo
Remove org.elasticsearch dependencies from API classes.
305d930 
Original Pull Request #1913
Closes #1884
Closes #1885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
type: task A general task
Projects
None yet
Milestone
4.3 M3 (2021.1.0)
Development

Successfully merging a pull request may close this issue.

Remove org.elasticsearch dependencies from API classes. sothawo/spring-data-elasticsearch
1 participant
@sothawo