Skip to content

Make integration tests configurable to use different containers #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sothawo opened this issue Jul 26, 2021 · 0 comments · Fixed by #1888
Closed

Make integration tests configurable to use different containers #1882

sothawo opened this issue Jul 26, 2021 · 0 comments · Fixed by #1888
Assignees
Labels
in: test tasks related to the test execution

Comments

@sothawo
Copy link
Collaborator

sothawo commented Jul 26, 2021

Currently tests and integration tests are separated by having a Junit @Tag with the value "integration-test" set on the test classes for integration tests. These tags are evaluated in the maven setup for the test and verify executions.

Integration tests start a Testcontainer with an Elasticsearch instance at the beginning of the integration tests and shut it down at the end.

In order to be able to develop Spring Data Elasticsearch to support different clients / systems like Elasticsearch or Opensearch, we need to be able to further add attributes to the integration tests defining which Testcontainer should be used. These attributes should be defined when starting the test, and should be evaluated when the tests are run.

It must be possible to disable tests or testclasses based on the chosen approach, for example if a test covers functionality that is provided by one system but not the other.

@sothawo sothawo added the in: test tasks related to the test execution label Jul 26, 2021
@sothawo sothawo added this to the 4.3 M2 (2021.1.0) milestone Jul 26, 2021
@sothawo sothawo self-assigned this Jul 26, 2021
sothawo added a commit that referenced this issue Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test tasks related to the test execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant