Skip to content

Queries defined with @Query are not using registered converters for parameter conversion. #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue Jul 14, 2021 · 0 comments · Fixed by #1867
Closed

Queries defined with @Query are not using registered converters for parameter conversion. #1866

sothawo opened this issue Jul 14, 2021 · 0 comments · Fixed by #1867
Assignees
@sothawo
Labels
type: bug A general bug
Milestone
4.3 M1 (2021.1.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Jul 14, 2021

When a repository method is defined with a @Query annotation and the registered conversions have a Converter registered for one of the method parameter types, this converter is not used when building the Elasticsearch query.
@sothawo sothawo self-assigned this Jul 14, 2021
@sothawo sothawo added the type: bug A general bug label Jul 14, 2021
@sothawo sothawo added this to the 4.3 M1 (2021.1.0) milestone Jul 14, 2021
@sothawo sothawo mentioned this issue Jul 14, 2021
Merged
sothawo added a commit that referenced this issue Jul 14, 2021
@sothawo
Use registered converters for parameters of @query annotated methods.
2709472 
Original Pull Request #1867 
Closes #1866
sothawo added a commit that referenced this issue Jul 14, 2021
@sothawo
Use registered converters for parameters of @query annotated methods.
6c40f0b 
Original Pull Request #1867
Closes #1866

(cherry picked from commit 2709472)
(cherry picked from commit 303438a)
(cherry picked from commit 626b274)
sothawo added a commit that referenced this issue Jul 14, 2021
@sothawo
Use registered converters for parameters of @query annotated methods.
626b274 
Original Pull Request #1867
Closes #1866

(cherry picked from commit 2709472)
(cherry picked from commit 303438a)
sothawo added a commit that referenced this issue Jul 14, 2021
@sothawo
Use registered converters for parameters of @query annotated methods.
303438a 
Original Pull Request #1867
Closes #1866

(cherry picked from commit 2709472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
type: bug A general bug
Projects
None yet
Milestone
4.3 M1 (2021.1.0)
1 participant
@sothawo