Skip to content

Fix fields and source_filter setup #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sothawo opened this issue May 17, 2021 · 0 comments · Fixed by #1819
Closed

Fix fields and source_filter setup #1817

sothawo opened this issue May 17, 2021 · 0 comments · Fixed by #1819
Assignees
Labels
type: bug A general bug

Comments

@sothawo
Copy link
Collaborator

sothawo commented May 17, 2021

The current code erroneously uses thefields parameter of a query and adds them to the source_filter of a query. But fields and source_filter define different things. fields is used to return the values that are contained in the mapping or scripted or runtime fields whereas source_filter is used to return the specified the given entries from the _source of the document.

This needs to be fixed. This might break code that relies on fields being interpreted as source_filter included fields.

@sothawo sothawo added the type: bug A general bug label May 17, 2021
@sothawo sothawo added this to the 4.3 M1 (2021.1.0) milestone May 17, 2021
@sothawo sothawo self-assigned this May 17, 2021
sothawo added a commit that referenced this issue May 18, 2021
Original Pull Request #1819 
Closes #1817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant