Skip to content

StringQuery execution crashes on return type SearchPage<T> #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue May 13, 2021 · 0 comments · Fixed by #1812
Closed

StringQuery execution crashes on return type SearchPage<T> #1811

sothawo opened this issue May 13, 2021 · 0 comments · Fixed by #1812
Assignees
@sothawo
Labels
type: bug A general bug
Milestone
4.3 M1 (2021.1.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented May 13, 2021

when a @Query annotated method has a return type of SearchPage<T> defined, the execution fails with a ClassCastException because internally the SearchPage return type is not handled correctly. ElasticsearchPartQuery (used for derived methods) works alright, there the return type is considered.
@sothawo sothawo added the type: bug A general bug label May 13, 2021
@sothawo sothawo self-assigned this May 13, 2021
sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue May 13, 2021
@sothawo
SearchPage result in StringQuery methods.
e41866f 
Closes spring-projects#1811
@sothawo sothawo mentioned this issue May 13, 2021
Merged
sothawo added a commit that referenced this issue May 13, 2021
@sothawo
SearchPage result in StringQuery methods.
e96d09f 
Original Pull Request #1812
Closes #1811
@sothawo sothawo added this to the 4.3 M1 (2021.1.0) milestone May 13, 2021
sothawo added a commit that referenced this issue May 13, 2021
@sothawo
SearchPage result in StringQuery methods.
ad6022f 
Original Pull Request #1812
Closes #1811

(cherry picked from commit e96d09f)
sothawo added a commit that referenced this issue May 14, 2021
@sothawo
SearchPage result in StringQuery methods.
26a3b32 
Original Pull Request #1812
Closes #1811

(cherry picked from commit e96d09f)
(cherry picked from commit ad6022f)
sothawo added a commit that referenced this issue May 14, 2021
@sothawo
SearchPage result in StringQuery methods.
a6adcef 
Original Pull Request #1812
Closes #1811

(cherry picked from commit e96d09f)
(cherry picked from commit ad6022f)
(cherry picked from commit 26a3b32)
@sothawo sothawo mentioned this issue Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
type: bug A general bug
Projects
None yet
Milestone
4.3 M1 (2021.1.0)
Development

Successfully merging a pull request may close this issue.

SearchPage result in StringQuery methods. sothawo/spring-data-elasticsearch
1 participant
@sothawo