Skip to content

Remove lombok #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sothawo opened this issue Mar 20, 2021 · 0 comments · Fixed by #1735
Closed

Remove lombok #1734

sothawo opened this issue Mar 20, 2021 · 0 comments · Fixed by #1735
Assignees
Labels
type: task A general task

Comments

@sothawo
Copy link
Collaborator

sothawo commented Mar 20, 2021

We already removed lombok from the production code. Now we see problems when trying to build the library with JDK16:

java: java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x39054474) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x39054474

We use lombok only in test code and only for generating getter/setter and constructors - nothing that any decent IDE could not generate as code as well. By removing lombok we will need to add some more boilerplate code to test entity classes, but we get rid of these JDK internal accessibility problems.

@sothawo sothawo added the type: task A general task label Mar 20, 2021
@sothawo sothawo self-assigned this Mar 20, 2021
sothawo added a commit that referenced this issue Mar 21, 2021
Original Pull Request #1735 
Closes #1734
@sothawo sothawo added this to the 4.2 RC1 (2021.0.0) milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant