Skip to content

Align MappingElasticsearchConverter with other Spring Data converters #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Feb 1, 2021 · 0 comments
Closed

Align MappingElasticsearchConverter with other Spring Data converters #1676

mp911de opened this issue Feb 1, 2021 · 0 comments
Assignees
@mp911de
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Feb 1, 2021 •
edited
Loading

  • Add support for SpEL expressions via @Value.
  • Simplify readCollectionOrArray to consider properly nested lists and maps
  • Simplify readMap to allow reading generic maps and entities in maps

This allows adding Document to ElasticsearchSimpleTypes.
Also, update DefaultElasticsearchTypeMapper to report a fallback TypeInformation to properly convert nested maps.

Related ticket: #1675.
@mp911de mp911de added the type: task A general task label Feb 1, 2021
@mp911de mp911de self-assigned this Feb 1, 2021
@mp911de mp911de changed the title Align MappingElasticsearchConverter with MongoDB converter Align MappingElasticsearchConverter with other Spring Data converters Feb 1, 2021
@mp911de mp911de mentioned this issue Feb 1, 2021
Closed
mp911de added a commit that referenced this issue Feb 1, 2021
@mp911de
Refactor MappingElasticsearchConverter.
02eb279 
* Add support for SpEL expressions via @value.
* Simplify readCollectionOrArray to consider properly nested lists and maps
* Simplify readMap to allow reading generic maps and entities in maps.
* Report a fallback TypeInformation in DefaultElasticsearchTypeMapper to properly convert nested maps.

Resolves #1676.
@mp911de mp911de mentioned this issue Feb 1, 2021
Closed
mp911de added a commit that referenced this issue Feb 3, 2021
@mp911de
Refactor MappingElasticsearchConverter.
877de9c 
* Add support for SpEL expressions via @value.
* Simplify readCollectionOrArray to consider properly nested lists and maps
* Simplify readMap to allow reading generic maps and entities in maps.
* Report a fallback TypeInformation in DefaultElasticsearchTypeMapper to properly convert nested maps.

We now no longer rely on isSimpleType when writing Maps. This is the preparation to consider Map as simple type.

Resolves #1676.
See #1675.
@sothawo sothawo closed this as completed in a2baea7 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor MappingElasticsearchConverter spring-projects/spring-data-elasticsearch
1 participant
@mp911de