Skip to content

Use own implementation of date formatters. #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue Jan 15, 2021 · 0 comments · Fixed by #1650
Closed

Use own implementation of date formatters. #1647

sothawo opened this issue Jan 15, 2021 · 0 comments · Fixed by #1650
Assignees
@sothawo
Labels
in: core Issues in core support type: task A general task
Milestone
4.2 M3 (2021.0.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Jan 15, 2021

Currently the ElasticsearchDateConverter has a dependency on org.elasticsearch.common.time.DateFormatter and org.elasticsearch.common.time.DateFormatter to convert Java classes to and from the different date formats that Elasticsearch supports.

These classes live in the core Elasticsearch library and not in one of the client libraries. To not risk licensing issues when ES changes it's license with 7.11, the formatting code must be implemented from scratch in Spring Data Elasticsearch.
@sothawo sothawo self-assigned this Jan 15, 2021
@sothawo sothawo added in: core Issues in core support type: task A general task labels Jan 15, 2021
@sothawo sothawo mentioned this issue Jan 17, 2021
Merged
@sothawo sothawo added this to the 4.2 M3 (2021.0.0) milestone Jan 17, 2021
sothawo added a commit that referenced this issue Jan 17, 2021
@sothawo
Use own implementation of date formatters.
c6713fa 
Original PR #1650 
Closes #1647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
in: core Issues in core support type: task A general task
Projects
None yet
Milestone
4.2 M3 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

Use own implementation of date formatters. sothawo/spring-data-elasticsearch
1 participant
@sothawo