Skip to content

Update Testcontainers dependency #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sothawo opened this issue Jan 7, 2021 · 0 comments · Fixed by #1635
Closed

Update Testcontainers dependency #1634

sothawo opened this issue Jan 7, 2021 · 0 comments · Fixed by #1635
Assignees
@sothawo
Labels
type: blocker An issue that is blocking us from releasing
Milestone
4.2 M2 (2021.0.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Jan 7, 2021

Testcontainers has a problem in downloading images when they are not in the docker server. This breaks the current builds when the images aren't preloaded.

Testcontainers version 1.15.1 fixes this.

This must be updated for current master branch and for 4.1.x
@sothawo sothawo added the type: blocker An issue that is blocking us from releasing label Jan 7, 2021
@sothawo sothawo added this to the 4.2 M2 (2021.0.0) milestone Jan 7, 2021
@sothawo sothawo self-assigned this Jan 7, 2021
sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue Jan 7, 2021
@sothawo
spring-projects#1634 - Update Testcontainers dependency.
09be375
@sothawo sothawo mentioned this issue Jan 7, 2021
Merged
sothawo added a commit that referenced this issue Jan 7, 2021
@sothawo
#1634 - Update Testcontainers dependency. (#1635)
6913d80 
Original Pull Request: #1635 
Closes #1634
sothawo added a commit that referenced this issue Jan 7, 2021
@sothawo
#1634 - Update Testcontainers dependency.
0086d35 
Original Pull Request: #1635
Closes #1634

(cherry picked from commit 6913d80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sothawo sothawo

Labels
type: blocker An issue that is blocking us from releasing
Projects
None yet
Milestone
4.2 M2 (2021.0.0)
Development

Successfully merging a pull request may close this issue.

#1634 - Update Testcontainers dependency. sothawo/spring-data-elasticsearch
1 participant
@sothawo