Skip to content

Commit e105648

Browse files
committed
Fix setting setting id in bulkrequest.
Original Pull Request #2862 Closes #2861 (cherry picked from commit debf04b) (cherry picked from commit b52e8d1)
1 parent a952e10 commit e105648

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -539,13 +539,12 @@ public IndexRequest<?> documentIndexRequest(IndexQuery query, IndexCoordinates i
539539
Object queryObject = query.getObject();
540540

541541
if (queryObject != null) {
542-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
543-
builder //
544-
.id(id) //
542+
builder
543+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
545544
.document(elasticsearchConverter.mapObject(queryObject));
546545
} else if (query.getSource() != null) {
547-
builder //
548-
.id(query.getId()) //
546+
builder
547+
.id(query.getId())
549548
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
550549
} else {
551550
throw new InvalidDataAccessApiUsageException(
@@ -591,12 +590,13 @@ private IndexOperation<?> bulkIndexOperation(IndexQuery query, IndexCoordinates
591590
Object queryObject = query.getObject();
592591

593592
if (queryObject != null) {
594-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
595-
builder //
596-
.id(id) //
593+
builder
594+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
597595
.document(elasticsearchConverter.mapObject(queryObject));
598596
} else if (query.getSource() != null) {
599-
builder.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
597+
builder
598+
.id(query.getId())
599+
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
600600
} else {
601601
throw new InvalidDataAccessApiUsageException(
602602
"object or source is null, failed to index the document [id: " + query.getId() + ']');
@@ -632,12 +632,13 @@ private CreateOperation<?> bulkCreateOperation(IndexQuery query, IndexCoordinate
632632
Object queryObject = query.getObject();
633633

634634
if (queryObject != null) {
635-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
636-
builder //
637-
.id(id) //
635+
builder
636+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
638637
.document(elasticsearchConverter.mapObject(queryObject));
639638
} else if (query.getSource() != null) {
640-
builder.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
639+
builder
640+
.id(query.getId())
641+
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
641642
} else {
642643
throw new InvalidDataAccessApiUsageException(
643644
"object or source is null, failed to index the document [id: " + query.getId() + ']');

0 commit comments

Comments
 (0)