Skip to content

Commit debf04b

Browse files
authored
Fix setting setting id in bulkrequest.
Original Pull Request #2862 Closes #2861
1 parent 205d74b commit debf04b

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

src/main/java/org/springframework/data/elasticsearch/client/elc/RequestConverter.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -546,13 +546,12 @@ public IndexRequest<?> documentIndexRequest(IndexQuery query, IndexCoordinates i
546546
Object queryObject = query.getObject();
547547

548548
if (queryObject != null) {
549-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
550-
builder //
551-
.id(id) //
549+
builder
550+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
552551
.document(elasticsearchConverter.mapObject(queryObject));
553552
} else if (query.getSource() != null) {
554-
builder //
555-
.id(query.getId()) //
553+
builder
554+
.id(query.getId())
556555
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
557556
} else {
558557
throw new InvalidDataAccessApiUsageException(
@@ -598,12 +597,13 @@ private IndexOperation<?> bulkIndexOperation(IndexQuery query, IndexCoordinates
598597
Object queryObject = query.getObject();
599598

600599
if (queryObject != null) {
601-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
602-
builder //
603-
.id(id) //
600+
builder
601+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
604602
.document(elasticsearchConverter.mapObject(queryObject));
605603
} else if (query.getSource() != null) {
606-
builder.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
604+
builder
605+
.id(query.getId())
606+
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
607607
} else {
608608
throw new InvalidDataAccessApiUsageException(
609609
"object or source is null, failed to index the document [id: " + query.getId() + ']');
@@ -639,12 +639,13 @@ private CreateOperation<?> bulkCreateOperation(IndexQuery query, IndexCoordinate
639639
Object queryObject = query.getObject();
640640

641641
if (queryObject != null) {
642-
String id = StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject);
643-
builder //
644-
.id(id) //
642+
builder
643+
.id(StringUtils.hasText(query.getId()) ? query.getId() : getPersistentEntityId(queryObject))
645644
.document(elasticsearchConverter.mapObject(queryObject));
646645
} else if (query.getSource() != null) {
647-
builder.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
646+
builder
647+
.id(query.getId())
648+
.document(new DefaultStringObjectMap<>().fromJson(query.getSource()));
648649
} else {
649650
throw new InvalidDataAccessApiUsageException(
650651
"object or source is null, failed to index the document [id: " + query.getId() + ']');

0 commit comments

Comments
 (0)