Skip to content

Commit 6f0d1ee

Browse files
committedNov 5, 2019
DATAES-684 - Polishing.
(cherry picked from commit 2475197)
1 parent f82dd22 commit 6f0d1ee

File tree

3 files changed

+14
-17
lines changed

3 files changed

+14
-17
lines changed
 

‎src/main/java/org/springframework/data/elasticsearch/client/reactive/ReactiveElasticsearchClient.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package org.springframework.data.elasticsearch.client.reactive;
1717

18-
import org.elasticsearch.action.bulk.BulkRequest;
19-
import org.elasticsearch.action.bulk.BulkResponse;
2018
import reactor.core.publisher.Flux;
2119
import reactor.core.publisher.Mono;
2220

@@ -32,6 +30,8 @@
3230
import org.elasticsearch.action.admin.indices.mapping.put.PutMappingRequest;
3331
import org.elasticsearch.action.admin.indices.open.OpenIndexRequest;
3432
import org.elasticsearch.action.admin.indices.refresh.RefreshRequest;
33+
import org.elasticsearch.action.bulk.BulkRequest;
34+
import org.elasticsearch.action.bulk.BulkResponse;
3535
import org.elasticsearch.action.delete.DeleteRequest;
3636
import org.elasticsearch.action.delete.DeleteResponse;
3737
import org.elasticsearch.action.get.GetRequest;
@@ -437,8 +437,8 @@ default Mono<BulkByScrollResponse> deleteBy(DeleteByQueryRequest deleteRequest)
437437
* Execute a {@link BulkRequest} against the {@literal bulk} API.
438438
*
439439
* @param consumer never {@literal null}.
440-
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk
441-
* API on elastic.co</a>
440+
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk API on
441+
* elastic.co</a>
442442
* @return a {@link Mono} emitting the emitting operation response.
443443
*/
444444
default Mono<BulkResponse> bulk(Consumer<BulkRequest> consumer) {
@@ -452,8 +452,8 @@ default Mono<BulkResponse> bulk(Consumer<BulkRequest> consumer) {
452452
* Execute a {@link BulkRequest} against the {@literal bulk} API.
453453
*
454454
* @param bulkRequest must not be {@literal null}.
455-
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk
456-
* API on elastic.co</a>
455+
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk API on
456+
* elastic.co</a>
457457
* @return a {@link Mono} emitting the emitting operation response.
458458
*/
459459
default Mono<BulkResponse> bulk(BulkRequest bulkRequest) {
@@ -465,8 +465,8 @@ default Mono<BulkResponse> bulk(BulkRequest bulkRequest) {
465465
*
466466
* @param headers Use {@link HttpHeaders} to provide eg. authentication data. Must not be {@literal null}.
467467
* @param bulkRequest must not be {@literal null}.
468-
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk
469-
* API on elastic.co</a>
468+
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk API on
469+
* elastic.co</a>
470470
* @return a {@link Mono} emitting operation response.
471471
*/
472472
Mono<BulkResponse> bulk(HttpHeaders headers, BulkRequest bulkRequest);

‎src/test/java/org/springframework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientTests.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import static org.assertj.core.api.Assertions.*;
1919

2020
import lombok.SneakyThrows;
21-
import org.elasticsearch.action.bulk.BulkRequest;
2221
import reactor.test.StepVerifier;
2322

2423
import java.io.IOException;
@@ -34,6 +33,7 @@
3433
import org.elasticsearch.Version;
3534
import org.elasticsearch.action.admin.indices.create.CreateIndexRequest;
3635
import org.elasticsearch.action.admin.indices.get.GetIndexRequest;
36+
import org.elasticsearch.action.bulk.BulkRequest;
3737
import org.elasticsearch.action.delete.DeleteRequest;
3838
import org.elasticsearch.action.get.GetRequest;
3939
import org.elasticsearch.action.get.MultiGetRequest;
@@ -669,18 +669,16 @@ public void bulkShouldUpdateExistingDocument() {
669669
bulkRequest.add(requestFirstDoc);
670670
bulkRequest.add(requestSecondDoc);
671671

672-
client.bulk(bulkRequest)
673-
.as(StepVerifier::create) //
672+
client.bulk(bulkRequest).as(StepVerifier::create) //
674673
.consumeNextWith(it -> {
675674
assertThat(it.status()).isEqualTo(RestStatus.OK);
676675
assertThat(it.hasFailures()).isFalse();
677676

678-
Arrays.stream(it.getItems()).forEach(itemResponse-> {
677+
Arrays.stream(it.getItems()).forEach(itemResponse -> {
679678
assertThat(itemResponse.status()).isEqualTo(RestStatus.OK);
680679
assertThat(itemResponse.getVersion()).isEqualTo(2);
681680
});
682-
})
683-
.verifyComplete();
681+
}).verifyComplete();
684682
}
685683

686684
private AddToIndexOfType addSourceDocument() {

‎src/test/java/org/springframework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientUnitTests.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import static org.mockito.Mockito.*;
2121
import static org.springframework.data.elasticsearch.client.reactive.ReactiveMockClientTestsUtils.MockWebClientProvider.Receive.*;
2222

23-
import org.elasticsearch.action.bulk.BulkRequest;
2423
import org.elasticsearch.rest.RestStatus;
2524
import reactor.core.publisher.Mono;
2625
import reactor.test.StepVerifier;
@@ -31,6 +30,7 @@
3130

3231
import org.elasticsearch.ElasticsearchStatusException;
3332
import org.elasticsearch.action.DocWriteResponse.Result;
33+
import org.elasticsearch.action.bulk.BulkRequest;
3434
import org.elasticsearch.action.delete.DeleteRequest;
3535
import org.elasticsearch.action.get.GetRequest;
3636
import org.elasticsearch.action.get.MultiGetRequest;
@@ -636,8 +636,7 @@ public void bulkShouldEmitResponseCorrectly() {
636636
final BulkRequest bulkRequest = new BulkRequest();
637637
bulkRequest.add(updateRequest);
638638

639-
client.bulk(bulkRequest)
640-
.as(StepVerifier::create) //
639+
client.bulk(bulkRequest).as(StepVerifier::create) //
641640
.consumeNextWith(bulkResponse -> {
642641

643642
assertThat(bulkResponse.status()).isEqualTo(RestStatus.OK);

0 commit comments

Comments
 (0)
Please sign in to comment.