Skip to content

Commit 2475197

Browse files
committed
DATAES-684 - Polishing.
1 parent 6ae4244 commit 2475197

File tree

3 files changed

+15
-18
lines changed

3 files changed

+15
-18
lines changed

src/main/java/org/springframework/data/elasticsearch/client/reactive/ReactiveElasticsearchClient.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package org.springframework.data.elasticsearch.client.reactive;
1717

18-
import org.elasticsearch.action.bulk.BulkRequest;
19-
import org.elasticsearch.action.bulk.BulkResponse;
2018
import reactor.core.publisher.Flux;
2119
import reactor.core.publisher.Mono;
2220

@@ -32,6 +30,8 @@
3230
import org.elasticsearch.action.admin.indices.mapping.put.PutMappingRequest;
3331
import org.elasticsearch.action.admin.indices.open.OpenIndexRequest;
3432
import org.elasticsearch.action.admin.indices.refresh.RefreshRequest;
33+
import org.elasticsearch.action.bulk.BulkRequest;
34+
import org.elasticsearch.action.bulk.BulkResponse;
3535
import org.elasticsearch.action.delete.DeleteRequest;
3636
import org.elasticsearch.action.delete.DeleteResponse;
3737
import org.elasticsearch.action.get.GetRequest;
@@ -436,8 +436,8 @@ default Mono<BulkByScrollResponse> deleteBy(DeleteByQueryRequest deleteRequest)
436436
* Execute a {@link BulkRequest} against the {@literal bulk} API.
437437
*
438438
* @param consumer never {@literal null}.
439-
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk
440-
* API on elastic.co</a>
439+
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk API on
440+
* elastic.co</a>
441441
* @return a {@link Mono} emitting the emitting operation response.
442442
*/
443443
default Mono<BulkResponse> bulk(Consumer<BulkRequest> consumer) {
@@ -451,8 +451,8 @@ default Mono<BulkResponse> bulk(Consumer<BulkRequest> consumer) {
451451
* Execute a {@link BulkRequest} against the {@literal bulk} API.
452452
*
453453
* @param bulkRequest must not be {@literal null}.
454-
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk
455-
* API on elastic.co</a>
454+
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk API on
455+
* elastic.co</a>
456456
* @return a {@link Mono} emitting the emitting operation response.
457457
*/
458458
default Mono<BulkResponse> bulk(BulkRequest bulkRequest) {
@@ -464,8 +464,8 @@ default Mono<BulkResponse> bulk(BulkRequest bulkRequest) {
464464
*
465465
* @param headers Use {@link HttpHeaders} to provide eg. authentication data. Must not be {@literal null}.
466466
* @param bulkRequest must not be {@literal null}.
467-
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk
468-
* API on elastic.co</a>
467+
* @see <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html">Bulk API on
468+
* elastic.co</a>
469469
* @return a {@link Mono} emitting operation response.
470470
*/
471471
Mono<BulkResponse> bulk(HttpHeaders headers, BulkRequest bulkRequest);

src/test/java/org/springframework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientTests.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import static org.assertj.core.api.Assertions.*;
1919

2020
import lombok.SneakyThrows;
21-
import org.elasticsearch.action.bulk.BulkRequest;
2221
import reactor.test.StepVerifier;
2322

2423
import java.io.IOException;
@@ -33,6 +32,7 @@
3332
import org.elasticsearch.ElasticsearchStatusException;
3433
import org.elasticsearch.Version;
3534
import org.elasticsearch.action.admin.indices.get.GetIndexRequest;
35+
import org.elasticsearch.action.bulk.BulkRequest;
3636
import org.elasticsearch.action.delete.DeleteRequest;
3737
import org.elasticsearch.action.get.GetRequest;
3838
import org.elasticsearch.action.get.MultiGetRequest;
@@ -667,18 +667,16 @@ public void bulkShouldUpdateExistingDocument() {
667667
bulkRequest.add(requestFirstDoc);
668668
bulkRequest.add(requestSecondDoc);
669669

670-
client.bulk(bulkRequest)
671-
.as(StepVerifier::create) //
670+
client.bulk(bulkRequest).as(StepVerifier::create) //
672671
.consumeNextWith(it -> {
673672
assertThat(it.status()).isEqualTo(RestStatus.OK);
674673
assertThat(it.hasFailures()).isFalse();
675674

676-
Arrays.stream(it.getItems()).forEach(itemResponse-> {
675+
Arrays.stream(it.getItems()).forEach(itemResponse -> {
677676
assertThat(itemResponse.status()).isEqualTo(RestStatus.OK);
678677
assertThat(itemResponse.getVersion()).isEqualTo(2);
679678
});
680-
})
681-
.verifyComplete();
679+
}).verifyComplete();
682680
}
683681

684682
private AddToIndexOfType addSourceDocument() {

src/test/java/org/springframework/data/elasticsearch/client/reactive/ReactiveElasticsearchClientUnitTests.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
import static org.mockito.Mockito.*;
2121
import static org.springframework.data.elasticsearch.client.reactive.ReactiveMockClientTestsUtils.MockWebClientProvider.Receive.*;
2222

23-
import org.elasticsearch.action.bulk.BulkRequest;
24-
import org.elasticsearch.rest.RestStatus;
2523
import reactor.core.publisher.Mono;
2624
import reactor.test.StepVerifier;
2725

@@ -31,6 +29,7 @@
3129

3230
import org.elasticsearch.ElasticsearchStatusException;
3331
import org.elasticsearch.action.DocWriteResponse.Result;
32+
import org.elasticsearch.action.bulk.BulkRequest;
3433
import org.elasticsearch.action.delete.DeleteRequest;
3534
import org.elasticsearch.action.get.GetRequest;
3635
import org.elasticsearch.action.get.MultiGetRequest;
@@ -40,6 +39,7 @@
4039
import org.elasticsearch.common.unit.TimeValue;
4140
import org.elasticsearch.common.xcontent.XContentType;
4241
import org.elasticsearch.index.VersionType;
42+
import org.elasticsearch.rest.RestStatus;
4343
import org.junit.jupiter.api.BeforeEach;
4444
import org.junit.jupiter.api.Test;
4545
import org.mockito.Mockito;
@@ -636,8 +636,7 @@ public void bulkShouldEmitResponseCorrectly() {
636636
final BulkRequest bulkRequest = new BulkRequest();
637637
bulkRequest.add(updateRequest);
638638

639-
client.bulk(bulkRequest)
640-
.as(StepVerifier::create) //
639+
client.bulk(bulkRequest).as(StepVerifier::create) //
641640
.consumeNextWith(bulkResponse -> {
642641

643642
assertThat(bulkResponse.status()).isEqualTo(RestStatus.OK);

0 commit comments

Comments
 (0)