Skip to content

Make CrudMethodMetadataPostProcessor public and make factory getTargetRepository() not final (so factory can be extended) #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikereiche opened this issue Dec 13, 2023 · 2 comments · Fixed by #1913
Closed

Make CrudMethodMetadataPostProcessor public and make factory getTargetRepository() not final (so factory can be extended) #1877

mikereiche opened this issue Dec 13, 2023 · 2 comments · Fixed by #1913
Assignees
@mikereiche

Comments

@mikereiche
Copy link
Collaborator

From #1873

For the custom repository - I don't know why the factory getTargetRepository() method is final. If it wasn't, you could just extend the existing couchbase factory. Similarily with the CrudMethodMetadataPostProcessor - if it was public, you could just use it instead of redefining it. Those two things can be changed to make your implementation a little easier.
@mikereiche mikereiche mentioned this issue Dec 21, 2023
Closed
@bipoool
Copy link
Contributor

bipoool commented Dec 27, 2023

Can I work on this @mikereiche ?

@bipoool
Copy link
Contributor

bipoool commented Jan 12, 2024

@mikereiche ?

@mikereiche mikereiche self-assigned this Jan 15, 2024
mikereiche added a commit that referenced this issue Mar 4, 2024
@mikereiche
Make CrudMethodMetadataPostProcessor public and make factory getTarge…
10a480e 
…tRepository() not final.

This is to ease extending spring-data-couchbase.

Closes #1877.
@mikereiche mikereiche mentioned this issue Mar 4, 2024
Merged
mikereiche added a commit that referenced this issue Mar 4, 2024
@mikereiche
Make CrudMethodMetadataPostProcessor public and make factory getTarge…
ff5ba5f 
…tRepository() not final. (#1913)

This is to ease extending spring-data-couchbase.

Closes #1877.
mikereiche added a commit that referenced this issue Mar 13, 2024
@mikereiche
Make CrudMethodMetadataPostProcessor public and make factory getTarge…
b18ee9d 
…tRepository() not final. (#1913)

This is to ease extending spring-data-couchbase.

Closes #1877.
mikereiche added a commit that referenced this issue Mar 13, 2024
@mikereiche
Make CrudMethodMetadataPostProcessor public and make factory getTarge…
e492ce4 
…tRepository() not final. (#1913)

This is to ease extending spring-data-couchbase.

Closes #1877.
mikereiche added a commit that referenced this issue Mar 13, 2024
@mikereiche
Make CrudMethodMetadataPostProcessor public and make factory getTarge…
1a8596a 
…tRepository() not final. (#1913)

This is to ease extending spring-data-couchbase.

Closes #1877.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikereiche mikereiche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CrudMethodMetadataPostProcessor public. spring-projects/spring-data-couchbase
2 participants
@mikereiche @bipoool