Skip to content

DATACMNS-577 - Improved javadoc on QueryDslPredicateExecutor. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

thomasdarimont
Copy link

No description provided.

thomasdarimont pushed a commit that referenced this pull request Oct 6, 2014
*/
public interface QueryDslPredicateExecutor<T> {

/**
* Returns a single entity matching the given {@link Predicate}.
* Returns a single entity matching the given {@link Predicate} or {@literal null} if none was found.
* If the predicate yields more than one result a {@link NonUniqueResultException} is thrown.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case, that's a bug. Repositories should only throw exceptions that inherit from DataAccessException.

thomasdarimont pushed a commit that referenced this pull request Oct 7, 2014
@thomasdarimont
Copy link
Author

Updated javadoc.

The findOne(..) method in org.springframework.data.jpa.repository.support.QueryDslJpaRepository
throws a QueryDSL specific com.mysema.query.NonUniqueResultException, when QueryDslJpaRepository is used directly (and without any exception translating proxy).

thomasdarimont pushed a commit that referenced this pull request Oct 8, 2014
Clarified return values if predicates don't match or return multiple results (for the findOne(…) method). Copied summary to the @return tag.

Original pull request: #96.
thomasdarimont pushed a commit that referenced this pull request Oct 8, 2014
Clarified return values if predicates don't match or return multiple results (for the findOne(…) method). Copied summary to the @return tag.

Original pull request: #96.
thomasdarimont pushed a commit that referenced this pull request Oct 8, 2014
Clarified return values if predicates don't match or return multiple results (for the findOne(…) method). Copied summary to the @return tag.

Original pull request: #96.
@odrotbohm odrotbohm closed this Oct 8, 2014
@odrotbohm odrotbohm deleted the issue/DATACMNS-577 branch October 8, 2014 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants