-
Notifications
You must be signed in to change notification settings - Fork 682
DATACMNS-1142 - Consider @Primary repository in Repositories if context is given. #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
janzeppenfeld
wants to merge
1
commit into
spring-projects:master
from
janzeppenfeld:issue/DATACMNS-1142
Closed
DATACMNS-1142 - Consider @Primary repository in Repositories if context is given. #465
janzeppenfeld
wants to merge
1
commit into
spring-projects:master
from
janzeppenfeld:issue/DATACMNS-1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt is given. In most of the current cases an ApplicationContext is passed to the Repositories constructor which is a ListableBeanFactory but not a ConfigurableListableBeanFactory. We now check whether the given ListableBeanFactory is of type ConfigurableApplicationContext as well because all current contexts implement this interface and therefore can return a ConfigurableListableBeanFactory. This way we can retrieve the bean definition for a repository and can check whether it has been marked as a primary one. Related tickets: DATACMNS-1448, DATACMNS-1591, DATAREST-923.
Thanks a lot. We're going to apply a slightly simplified variant of the fix while retaining your test contribution. |
Thank you for your contribution. That's merged, polished, and backported now. |
Thanks for the feedback and glad to give something back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most of the current cases an ApplicationContext is passed to the Repositories constructor which is a ListableBeanFactory but not a ConfigurableListableBeanFactory. We now check whether the given ListableBeanFactory is of type ConfigurableApplicationContext as well because all current contexts implement this interface and therefore can return a ConfigurableListableBeanFactory. This way we can retrieve the bean definition for a repository and can check whether it has been marked as a primary one.
Related tickets: DATACMNS-1448, DATACMNS-1591, DATAREST-923.