DATACMNS-1596 - Modules not exposing identifying annotations do not claim repository interfaces anymore. #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laim repository interfaces anymore. Previously, a module not exposing any entity identifying annotations would have claimed a repository definition and potentially overrode the bean definition of another store that was the proper claim in the first place. We have now changed this to abstain from a claim of the interface. We' also tweaked the log output in the following cases: 1. If the module neither returns an identifying type nor entity identifying annotations, we now log a warning that a module does not support a multi-module setup and answer all assignment requests with false. 2. The info level warning indicating an interface has been dropped now reports which annotations or interface base types to use. Original pull request: #411. Related tickets: spring-projects/spring-boot#18721
odrotbohm
force-pushed
the
issue/DATACMNS-1596
branch
from
f948a7f to
4e29b45
Compare
mp911de
pushed a commit
that referenced
this pull request
Oct 24, 2019
…laim repository interfaces anymore. Previously, a module not exposing any entity identifying annotations would have claimed a repository definition and potentially overrode the bean definition of another store that was the proper claim in the first place. We have now changed this to abstain from a claim of the interface. We' also tweaked the log output in the following cases: 1. If the module neither returns an identifying type nor entity identifying annotations, we now log a warning that a module does not support a multi-module setup and answer all assignment requests with false. 2. The info level warning indicating an interface has been dropped now reports which annotations or interface base types to use. Original pull request: #411. Related tickets: spring-projects/spring-boot#18721
mp911de
added a commit
that referenced
this pull request
Oct 24, 2019
Fix Javadoc method reference. Original pull request: #411.
mp911de
pushed a commit
that referenced
this pull request
Oct 24, 2019
…laim repository interfaces anymore. Previously, a module not exposing any entity identifying annotations would have claimed a repository definition and potentially overrode the bean definition of another store that was the proper claim in the first place. We have now changed this to abstain from a claim of the interface. We' also tweaked the log output in the following cases: 1. If the module neither returns an identifying type nor entity identifying annotations, we now log a warning that a module does not support a multi-module setup and answer all assignment requests with false. 2. The info level warning indicating an interface has been dropped now reports which annotations or interface base types to use. Original pull request: #411. Related tickets: spring-projects/spring-boot#18721
mp911de
added a commit
that referenced
this pull request
Oct 24, 2019
Fix Javadoc method reference. Original pull request: #411.
mp911de
pushed a commit
that referenced
this pull request
Oct 24, 2019
…laim repository interfaces anymore. Previously, a module not exposing any entity identifying annotations would have claimed a repository definition and potentially overrode the bean definition of another store that was the proper claim in the first place. We have now changed this to abstain from a claim of the interface. We' also tweaked the log output in the following cases: 1. If the module neither returns an identifying type nor entity identifying annotations, we now log a warning that a module does not support a multi-module setup and answer all assignment requests with false. 2. The info level warning indicating an interface has been dropped now reports which annotations or interface base types to use. Original pull request: #411. Related tickets: spring-projects/spring-boot#18721
mp911de
added a commit
that referenced
this pull request
Oct 24, 2019
Fix Javadoc method reference. Original pull request: #411.
|
That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a module not exposing any entity identifying annotations would have claimed a repository definition and potentially overrode the bean definition of another store that was the proper claim in the first place. We have now changed this to abstain from a claim of the interface.
We' also tweaked the log output in the following cases:
If the module neither returns an identifying type nor entity identifying annotations, we now log a warning that a module does not support a multi-module setup and answer all assignment requests with false.
The info level warning indicating an interface has been dropped now reports which annotations or interface base types to use.
Related tickets: spring-projects/spring-boot#18721