Skip to content

DATACMNS-1598 - fix projection with EnumSet #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DATACMNS-1598 - fix projection with EnumSet #409

wants to merge 1 commit into from

Conversation

wilds
Copy link
Contributor

@wilds wilds commented Oct 14, 2019

When you try to apply a projecton to an entity with some EnumSet field, it fails with "Cannot create EnumSet for unknown element type"

Problem related to: spring-projects/spring-boot#15539

@mp911de
Copy link
Member

mp911de commented Oct 16, 2019

Please provide a test along with your changes and please point your PR to master. Care to also file a ticket at https://jira.spring.io?

@wilds wilds changed the base branch from 2.1.x to master October 26, 2019 00:34
@wilds wilds closed this Oct 26, 2019
@wilds wilds reopened this Oct 26, 2019
@wilds wilds changed the title fix projection with EnumSet DATACMNS-1598 - fix projection with EnumSet Oct 26, 2019
@wilds
Copy link
Contributor Author

wilds commented Oct 26, 2019

Ticket created: https://jira.spring.io/browse/DATACMNS-1598
Test provvided as attachment on the ticket.
If you run "mvn test" on the sample project provided, it throws "Cannot create EnumSet for unknown element type". If you apply the patch it starts to works as expected.

mp911de pushed a commit that referenced this pull request Oct 28, 2019
EnumSet's are now constructed with a proper component type.

Original pull request: #409.
mp911de added a commit that referenced this pull request Oct 28, 2019
Add unit tests to back change. Guard invocations against null dereference.
Join assertions.

Original pull request: #409.
mp911de pushed a commit that referenced this pull request Oct 28, 2019
EnumSet's are now constructed with a proper component type.

Original pull request: #409.
mp911de added a commit that referenced this pull request Oct 28, 2019
Add unit tests to back change. Guard invocations against null dereference.
Join assertions.

Original pull request: #409.
mp911de pushed a commit that referenced this pull request Oct 28, 2019
EnumSet's are now constructed with a proper component type.

Original pull request: #409.
mp911de added a commit that referenced this pull request Oct 28, 2019
Add unit tests to back change. Guard invocations against null dereference.
Join assertions.

Original pull request: #409.
@mp911de
Copy link
Member

mp911de commented Oct 28, 2019

Thanks a lot for your contribution. That's merged, polished, and backported now. You might want to take a look at cace881 for a JUnit test for projections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants