Skip to content

Refining QBE documentation #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>org.springframework.data</groupId>
<artifactId>spring-data-commons</artifactId>
<version>3.5.0-SNAPSHOT</version>
<version>3.5.0-qbe-documentation-SNAPSHOT</version>

<name>Spring Data Core</name>
<description>Core Spring concepts underpinning every Spring Data module.</description>
Expand Down
7 changes: 7 additions & 0 deletions src/main/antora/modules/ROOT/pages/query-by-example.adoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
ifndef::support-qbe-collection[]
:support-qbe-collection: true
endif::[]

[[query-by-example]]
= Query by Example

Expand Down Expand Up @@ -36,6 +40,9 @@ Query by Example is well suited for several use cases:
Query by Example also has several limitations:

* No support for nested or grouped property constraints, such as `firstname = ?0 or (firstname = ?1 and lastname = ?2)`.
ifeval::[{support-qbe-collection} != true]
* No support for matching collections or maps.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This limitation only applies to JPA and JDBC. MongoDB does not have this limitation. We could make the bullet point conditional to switch it on/off as needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do so.

endif::[]
* Store-specific support on string matching.
Depending on your databases, String matching can support starts/contains/ends/regex for strings.
* Exact matching for other property types.
Expand Down