Add PageRequest builder #322
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasXPX
approved these changes
Nov 7, 2020
spring-projects-issues
added
the
status: waiting-for-triage
schauder
added
type: enhancement
mp911de
added a commit
that referenced
this pull request
Jan 28, 2021
Introduce factory methods on Pageable, PageRequest, and QPageRequest to construct PageRequest objects. Replace builder with with…(…) methods. Closes #322.
|
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal PR for adding builder for
PageRequestclass.Every time I see
PageRequest.of(0, 10)in code I need to go intoPageRequestto make sure that parameters were not mixed up. I think that having both parameters of the same type in constructor/static initializer is error prone. In this PR I would like to show you an example of how readablePageRequestcould be. Please take a look. Thanks