Skip to content

Remove branching overhead in BytecodeUtil by replacing if with else if #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mitu2
Copy link
Contributor

@mitu2 mitu2 commented Sep 29, 2024

This method does not return in time after an internal match succeeds, resulting in code overhead.

If there is anything wrong with the first PR, please point it out

@pivotal-cla
Copy link

@mitu2 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 29, 2024
@pivotal-cla
Copy link

@mitu2 Thank you for signing the Contributor License Agreement!

@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 8, 2024
@mp911de mp911de changed the title fix BytecodeUtil if to else if Remove branching overhead in BytecodeUtil by replacing if with else if Oct 8, 2024
@mp911de mp911de self-assigned this Mar 5, 2025
mp911de pushed a commit that referenced this pull request Mar 5, 2025
mp911de added a commit that referenced this pull request Mar 5, 2025
Reformat code.

See #3168
@mp911de mp911de closed this in 258ed3a Mar 5, 2025
mp911de added a commit that referenced this pull request Mar 5, 2025
Reformat code.

See #3168
mp911de pushed a commit that referenced this pull request Mar 5, 2025
mp911de added a commit that referenced this pull request Mar 5, 2025
Reformat code.

See #3168
@mp911de
Copy link
Member

mp911de commented Mar 5, 2025

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de added this to the 3.3.10 (2024.0.10) milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants