Add RepositoryMetadataAccess interface
#3145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repositories that detect fragment implementations implementing RepositoryMetadataAccess enable metadata exposure regardless of the exposeMetadata flag.
mp911de
changed the title
RepositoryMetadataAccessRepositoryMetadataAccess interface
mp911de
commented
Sep 3, 2024
| * @param implementation | ||
| * @deprecated since 3.4 - use {@link ImplementedRepositoryFragment(Class, Object)} instead. | ||
| */ | ||
| @Deprecated(since = "3.4") |
There was a problem hiding this comment.
Let's add a forRemoval=true so that we clean up the API with Spring Data 4.0
mp911de
commented
Sep 3, 2024
| } | ||
| return (Class<T>) implementation.getClass(); | ||
| }); | ||
| if(interfaceClass != null) { |
mp911de
commented
Sep 3, 2024
| @@ -216,7 +228,7 @@ public RepositoryFragment<T> withImplementation(T implementation) { | |||
| public String toString() { | |||
|
|
|||
| return String.format("ImplementedRepositoryFragment %s%s", | |||
| interfaceClass.map(ClassUtils::getShortName).map(it -> it + ":").orElse(""), | |||
| interfaceClass != null ? (ClassUtils.getShortName(interfaceClass) + ";") : "", | |||
There was a problem hiding this comment.
Nit: A slight change in : vs. ;
christophstrobl
added a commit
that referenced
this pull request
Sep 4, 2024
Update documentation. Additional logging for repository bootstrap procedure. Limit usage of Optional in RepositoryFragment. Original Pull Request: #3145
mipo256
pushed a commit
to mipo256/spring-data-commons
that referenced
this pull request
Sep 21, 2024
Repositories that detect fragment implementations implementing RepositoryMetadataAccess enable metadata exposure regardless of the exposeMetadata flag. See: spring-projects#3090 Original Pull Request: spring-projects#3145
mipo256
pushed a commit
to mipo256/spring-data-commons
that referenced
this pull request
Sep 21, 2024
Update documentation. Additional logging for repository bootstrap procedure. Limit usage of Optional in RepositoryFragment. Original Pull Request: spring-projects#3145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositories that detect fragment implementations implementing
RepositoryMetadataAccessenable metadata exposure regardless of theexposeMetadataflag on the repository factory.