Skip to content

refactor: improved readability of pageableExecutionUtils #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor: improved readability of pageableExecutionUtils #3113

wants to merge 1 commit into from

Conversation

erie0210
Copy link
Contributor

@erie0210 erie0210 commented Jun 24, 2024 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

resolves #3103

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 24, 2024
@erie0210 erie0210 force-pushed the refactor/pageable-execution-utils branch from 022f8dd to d63f5f3 Compare June 24, 2024 10:08
schauder pushed a commit that referenced this pull request Jul 1, 2024
@erie0210 @schauder
Refactor PageableExecutionUtils.
47109d4 
Closes #3103
Original pull request #3113
schauder added a commit that referenced this pull request Jul 1, 2024
@schauder
Further refactoring of PageableExecutionUtils.
9ab34d8 
Removing `isSubsequentPage`. It is another name for !isFirstPage suggesting a different meaning which isn't there.

Extracting `if (isFirstPage(pageable)) {`, further structuring the decision tree.

See #3103
Original pull request #3113
@schauder
Copy link
Contributor

schauder commented Jul 1, 2024

Thanks, that is polished and merged.

@schauder schauder closed this Jul 1, 2024
@injae-kim
Copy link

Nice work @erie0210 ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schauder schauder

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Increases readability of PageableExecutionUtils code
4 participants
@erie0210 @schauder @injae-kim @spring-projects-issues