Use -1 instead of null as initial offset
#3075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use type `long` instead of `Long` to keep it consistent with previous version. 2. Position function is simplified to `offset+1`.
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: task
mp911de
added a commit
that referenced
this pull request
Apr 15, 2024
Reformat code. Use explicit local variable types instead of var. See #3075
|
Thank you for your contribution. That's merged and polished now. |
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-commons
that referenced
this pull request
May 20, 2024
1. Use type `long` instead of `Long` to keep it consistent with previous version. 2. Position function is simplified to `offset+1`. Closes spring-projects#3075
natedanner
pushed a commit
to natedanner/spring-projects__spring-data-commons
that referenced
this pull request
May 20, 2024
Reformat code. Use explicit local variable types instead of var. See spring-projects#3075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longinstead ofLongto keep it consistent with previous version.offset+1.