Skip to content

Treat Page and Window as Collection for event publishing #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Treat Page and Window as Collection for event publishing #2931

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Sep 15, 2023

repository.saveAll(Window<?>) will be handled properly after this commit.

Fixes #2938

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 15, 2023
@quaff
Copy link
Contributor Author

quaff commented Sep 15, 2023

Supersede #2931

@quaff quaff changed the title Treat Window as Collection for event publishing Treat Page and Window as Collection for event publishing Sep 15, 2023
@quaff quaff mentioned this pull request Sep 15, 2023
Closed
odrotbohm added a commit that referenced this pull request Sep 20, 2023
@odrotbohm
Properly emit domain events from calls to saveAll(…).
f9bc97f 
We now treat CrudRepository.saveAll(…) properly by unwrapping the given *Iterable*. This previously already worked for collections handed into the method but not for types only implementing Iterable directly (like Page or Window).

Fixes #3153.
Related tickets #2931, #2927.
odrotbohm added a commit that referenced this pull request Sep 20, 2023
@odrotbohm
Properly emit domain events from calls to saveAll(…).
880b141 
We now treat CrudRepository.saveAll(…) properly by unwrapping the given *Iterable*. This previously already worked for collections handed into the method but not for types only implementing Iterable directly (like Page or Window).

Fixes #3153.
Related tickets #2931, #2927.
odrotbohm added a commit that referenced this pull request Sep 20, 2023
@odrotbohm
Properly emit domain events from calls to saveAll(…).
5f64564 
We now treat CrudRepository.saveAll(…) properly by unwrapping the given *Iterable*. This previously already worked for collections handed into the method but not for types only implementing Iterable directly (like Page or Window).

Fixes #3153.
Related tickets #2931, #2927.
odrotbohm added a commit that referenced this pull request Sep 20, 2023
@odrotbohm
Properly emit domain events from calls to saveAll(…).
36e734e 
We now treat CrudRepository.saveAll(…) properly by unwrapping the given *Iterable*. This previously already worked for collections handed into the method but not for types only implementing Iterable directly (like Page or Window).

Fixes #3153.
Related tickets #2931, #2927.
@odrotbohm odrotbohm removed the status: waiting-for-triage An issue we've not yet triaged label Sep 20, 2023
@odrotbohm
Copy link
Member

Superseded by the fix for #2938.

@odrotbohm odrotbohm closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@odrotbohm odrotbohm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@DomainEvents method not being called on saveAll with Window<>
3 participants
@quaff @odrotbohm @spring-projects-issues