Skip to content

Introduce argument resolver for OffsetScrollPosition #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Introduce argument resolver for OffsetScrollPosition #2861

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 16, 2023

See GH-2856

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 16, 2023
@quaff
Copy link
Contributor Author

quaff commented Jun 17, 2023

Should the class names OffsetScrollPosition* be simplified as Offset*?

@mp911de mp911de self-assigned this Jun 19, 2023
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 19, 2023
@mp911de mp911de mentioned this pull request Jun 19, 2023
Open
@mp911de
Copy link
Member

mp911de commented Jul 4, 2023

Should the class names OffsetScrollPosition* be simplified as Offset*?

It is fine to have fully-qualified class names as we want to be explicit about the type of arguments we want to resolve.

@mp911de mp911de changed the title Implement argument resolver for OffsetScrollPosition Introduce argument resolver for OffsetScrollPosition Jul 4, 2023
@mp911de mp911de linked an issue Jul 4, 2023 that may be closed by this pull request
Introduce argument resolver for OffsetScrollPosition #2856
Closed
@mp911de mp911de added this to the 3.2 M1 (2023.1.0) milestone Jul 4, 2023
@mp911de
Copy link
Member

mp911de commented Jul 4, 2023

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Jul 4, 2023
mp911de pushed a commit that referenced this pull request Jul 4, 2023
@quaff @mp911de
Introduce argument resolver for OffsetScrollPosition.
391607b 
Closes #2856
Original pull request: #2861
mp911de added a commit that referenced this pull request Jul 4, 2023
@mp911de
Polishing.
80b8e12 
Allow nullable OffsetScrollPosition and add support for values wrapped within Optional.

Update tests. Reformat code. Add issue tags to tests.

See #2856
Original pull request: #2861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2 M1 (2023.1.0)
Development

Successfully merging this pull request may close these issues.

Introduce argument resolver for OffsetScrollPosition
3 participants
@quaff @mp911de @spring-projects-issues