Skip to content

Fix outdated Javadoc #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
/**
* Argument resolver to extract a {@link Pageable} object from a {@link NativeWebRequest} for a particular
* {@link MethodParameter}. A {@link PageableArgumentResolver} can either resolve {@link Pageable} itself or wrap
* another {@link PageableArgumentResolver} to post-process {@link Pageable}. {@link Pageable} resolution yields either
* in a {@link Pageable} object or {@literal null} if {@link Pageable} cannot be resolved.
* another {@link PageableArgumentResolver} to post-process {@link Pageable}.
*
* @author Mark Paluch
* @since 1.13
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
/**
* Argument resolver to extract a {@link Sort} object from a {@link NativeWebRequest} for a particular
* {@link MethodParameter}. A {@link SortArgumentResolver} can either resolve {@link Sort} itself or wrap another
* {@link SortArgumentResolver} to post-process {@link Sort}. {@link Sort} resolution yields either in a {@link Sort}
* object or {@literal null} if {@link Sort} cannot be resolved.
* {@link SortArgumentResolver} to post-process {@link Sort}.
*
* @author Mark Paluch
* @since 1.13
Expand All @@ -45,7 +44,7 @@ public interface SortArgumentResolver extends HandlerMethodArgumentResolver {
* @param mavContainer the ModelAndViewContainer for the current request
* @param webRequest the current request
* @param binderFactory a factory for creating {@link WebDataBinder} instances
* @return the resolved argument value, or {@code null}
* @return the resolved argument value
*/
@NonNull
@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ void sizeParamIsNotNumeric() throws Exception {
}

@Test // DATACMNS-477
void returnsNullIfFallbackIsUnpagedAndNoParametersGiven() throws Exception {
void returnsUnpagedIfFallbackIsUnpagedAndNoParametersGiven() throws Exception {

var resolver = getResolver();
resolver.setFallbackPageable(Pageable.unpaged());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ void sizeParamIsNotNumeric() {
}

@Test // DATACMNS-1211
void returnsNullIfFallbackIsUnpagedAndNoParametersGiven() {
void returnsUnpagedIfFallbackIsUnpagedAndNoParametersGiven() {

var resolver = getReactiveResolver();
resolver.setFallbackPageable(Pageable.unpaged());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void supportsSortParameter() {
}

@Test // DATACMNS-1211
void returnsNullForNoDefault() {
void returnsUnsortedForNoDefault() {
assertSupportedAndResolvedTo(getParameterOfMethod("supportedMethod"), Sort.unsorted());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ void supportsSortParameter() {
}

@Test
void returnsNullForNoDefault() throws Exception {
void returnsUnsortedForNoDefault() throws Exception {
assertSupportedAndResolvedTo(getParameterOfMethod("supportedMethod"), Sort.unsorted());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ void discoversQualifiedSortFromRequest() {
}

@Test
void returnsNullForSortParameterSetToNothing() {
void returnsUnsortedForSortParameterSetToNothing() {

var parameter = getParameterOfMethod("supportedMethod");

Expand Down