Skip to content

Emit items in order when scrolling backwards using WindowIterator. #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Emit items in order when scrolling backwards using WindowIterator. #2858

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

Closes: #2857

@mp911de mp911de added this to the 3.1.1 (2023.0.1) milestone Jun 16, 2023
@mp911de mp911de added the type: bug A general bug label Jun 16, 2023
mp911de pushed a commit that referenced this pull request Jun 16, 2023
@christophstrobl @mp911de
WindowIterator should emit items in order when scrolling backwards.
d156819 
Closes #2857
Original pull request: #2858
mp911de added a commit that referenced this pull request Jun 16, 2023
@mp911de
Polishing.
6ca3170 
Use ReverseListIterator instead of Stream API to reduce overhead. ListIterator provides means to iterate backwards so we're wrapping the existing iterator.

See #2857.
Original pull request: #2858.
mp911de pushed a commit that referenced this pull request Jun 16, 2023
@christophstrobl @mp911de
WindowIterator should emit items in order when scrolling backwards.
8671c00 
Closes #2857
Original pull request: #2858
mp911de added a commit that referenced this pull request Jun 16, 2023
@mp911de
Polishing.
60877d7 
Use ReverseListIterator instead of Stream API to reduce overhead. ListIterator provides means to iterate backwards so we're wrapping the existing iterator.

See #2857.
Original pull request: #2858.
@mp911de
Copy link
Member

mp911de commented Jun 16, 2023

That's merged, polished, and backported now.

@mp911de mp911de closed this Jun 16, 2023
@mp911de mp911de deleted the issue/2857 branch June 16, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.1 (2023.0.1)
Development

Successfully merging this pull request may close these issues.

WindowIterator should emit items in order when scrolling backwards.
2 participants
@christophstrobl @mp911de